Opened on 11/06/2014 at 11:21:48 AM
Closed on 02/12/2015 at 11:21:47 AM
#1535 closed change (fixed)
Replace ABP icon with new one (v.1.1) - for Chrome/Opera/Safari
| Reported by: | sven | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-1.8.11-for-Chrome-Opera-Safari |
| Module: | User-Interface | Keywords: | |
| Cc: | trev, sebastian | Blocked By: | |
| Blocking: | #1533 | Platform: | Chrome |
| Ready: | no | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): |
http://codereview.adblockplus.org/6200136564736000 |
||
Description (last modified by sven)
Background
We've created a new icon that was announced and discussed in our blog and in our forum. After some improvements the 1.1 and 1.2 versions are ready to implement now.
What to change
In general: Replace the current ABP icons with the new ones.
In detail:
| filename | platform | newfile |
| icons/abp-16.png | chromium/safari | active_16_v_1_1.png |
| icons/abp-32.png | chromium/safari | active_32_v_1_1.png |
| icons/abp-128.png | chromium/safari | 128px-active_v1_2.png |
| chrome/icons/abp-19.png | chromium | active_19_v_1_1.png |
| chrome/icons/abp-19-whitelisted.png | chromium | inactive_19_v_1_1.png |
| chrome/icons/abp-19-notification-information.png | chromium | questionmark_19_v_1_1.png |
| chrome/icons/abp-19-notification-critical.png | chromium | exclamationmark_19_v_1_1.png |
| chrome/icons/abp-38.png | chromium | active_38_v_1_1.png |
| chrome/icons/abp-38-whitelisted.png | chromium | inactive_38_v_1_1.png |
| chrome/icons/abp-38-notification-information.png | chromium | questionmark_38_v_1_1.png |
| chrome/icons/abp-38-notification-critical.png | chromium | exclamationmark_38_v_1_1.png |
| chrome/icons/abp-48.png | chromium | 48px-active_v1_2.png |
| safari/icons/abp-16-notification-information.png | safari | questionmark_16_v_1_1.png |
| safari/icons/abp-16-notification-critical.png | safari | exclamationmark_16_v_1_1.png |
| safari/icons/abp-32-notification-information.png | safari | questionmark_32_v_1_1.png |
| safari/icons/abp-32-notification-critical.png | safari | exclamationmark_32_v_1_1.png |
The whole list of used icons in the extension can be found here
@palant mentioned in #1534: "All images are overly large, they should go through pngout first."
Attachments (7)
Change History (24)
Changed on 11/06/2014 at 11:28:16 AM by sven
comment:1 Changed on 11/06/2014 at 11:41:27 AM by sven
- Blocking 1533 added
comment:2 Changed on 11/11/2014 at 08:53:59 AM by fhd
- Priority changed from P2 to P3
comment:3 Changed on 12/04/2014 at 10:52:22 AM by fhd
Unsetting ready for now - Sven would still like to go over this with the new designer in January.
comment:4 Changed on 01/23/2015 at 03:33:36 PM by sven
- Description modified (diff)
- Summary changed from Replace ABP icon with new one (v.1.0) - for Google Chrome to Replace ABP icon with new one (v.1.1) - for Google Chrome
Changed on 01/23/2015 at 03:34:12 PM by sven
ABP icons v.1.1
comment:5 Changed on 01/23/2015 at 03:37:08 PM by sven
- Platform changed from Unknown to Chrome
comment:6 Changed on 01/23/2015 at 03:40:39 PM by sven
We improved the 16px and the 19px version (v1.1). It's ready to implement now.
comment:7 Changed on 01/23/2015 at 03:46:00 PM by sven
- Cc sebastian trev added
comment:8 Changed on 01/26/2015 at 01:31:59 PM by sebastian
- Summary changed from Replace ABP icon with new one (v.1.1) - for Google Chrome to Replace ABP icon with new one (v.1.1) - for Chrome/Opera/Safari
comment:9 Changed on 01/26/2015 at 02:05:27 PM by sebastian
We also need an icon in 48x48 (shown in notifications) and 128x128 (shown when installing the extension and in the list of installed extensions).
Changed on 01/26/2015 at 02:13:49 PM by christiane
Changed on 01/26/2015 at 02:14:06 PM by christiane
comment:10 Changed on 01/26/2015 at 02:14:52 PM by christiane
48x48 and 128x128 active added. see above.
comment:11 Changed on 01/26/2015 at 02:16:47 PM by sebastian
- Cc sebastian removed
- Owner set to sebastian
- Ready set
Thanks.
comment:12 Changed on 01/26/2015 at 02:33:52 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:13 Changed on 01/27/2015 at 10:57:05 AM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:14 Changed on 01/27/2015 at 04:17:26 PM by sebastian
- Review URL(s) modified (diff)
Changed on 02/12/2015 at 10:16:47 AM by sven
Changed on 02/12/2015 at 10:18:51 AM by sven
Changed on 02/12/2015 at 10:18:59 AM by sven
comment:15 Changed on 02/12/2015 at 10:50:26 AM by sven
- Cc sebastian added
- Description modified (diff)
- Ready unset
- Resolution fixed deleted
- Status changed from closed to reopened
comment:16 Changed on 02/12/2015 at 10:50:53 AM by sven
- Description modified (diff)
comment:17 Changed on 02/12/2015 at 11:21:47 AM by sebastian
- Resolution set to fixed
- Status changed from reopened to closed
This issue has already been implemented, as initially specified. So please don't reopen it, for further changes. See #1989 for changing the 48px and 128px icon again.
ABP icons v.1.0