Opened on 10/27/2015 at 02:28:42 PM
Closed on 11/02/2015 at 12:32:23 PM
#3238 closed defect (fixed)
Adblock Warning List opt in message should not be triggered by frames (Chrome)
| Reported by: | arthur | Assignee: | trev |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-for-1.9.4-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Chrome | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by trev)
Environment
Chrome 46 (Safari and Opera are probably affected as well)
Windows 10 64 bit
Adblock Plus 1.9.3
How to reproduce
- Install ABP in a new browser profile
- Go to http://www.gutefrage.net/fragen/beliebte/1/30
- Disable ABP on that domain
- Refresh the page
Observed behaviour
The opt in message for adblock warnings shows up (triggered by the ligatus.com frame).
Expected behaviour
It should not show up, since the top-level document (gutefrage.net) doesn't match anything.
Attachments (0)
Change History (9)
comment:1 Changed on 10/29/2015 at 04:13:59 PM by kzar
- Priority changed from Unknown to P3
- Ready set
comment:3 Changed on 11/02/2015 at 10:55:34 AM by Kai
I may add that the notification has no impact on the sites in question even if you click on OK. So the notification is a annoyance to the user and should be removed quickly.
comment:4 Changed on 11/02/2015 at 11:04:31 AM by trev
- Component changed from Unknown to Platform
- Description modified (diff)
- Priority changed from P3 to P2
@kzar: An issue without module isn't "ready" by definition ;)
There are actually three separate issues here. One is that Adblock Plus for Chrome checks frames for the anti-adblock notification rather than top-level documents only. The other is that Adblock Plus for Firefox seems to do the same (entirely different code). And finally, there is the issue that showing the anti-adblock notifications when Adblock Plus is disabled makes very little sense.
I'll morph this ticket into reflecting the first issue and create follow-ups on the other issues.
comment:5 Changed on 11/02/2015 at 11:05:03 AM by trev
- Summary changed from Adblock Warning List opt in message should not be triggered when ABP is disabled to Adblock Warning List opt in message should not be triggered by frames (Chrome)
comment:7 Changed on 11/02/2015 at 11:23:42 AM by trev
- Owner changed from greiner to trev
comment:8 Changed on 11/02/2015 at 11:26:16 AM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:9 Changed on 11/02/2015 at 12:32:23 PM by trev
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
I could reproduce this issue as described.