Opened on 03/11/2014 at 03:24:56 PM
Closed on 08/11/2014 at 11:56:21 AM
#46 closed change (fixed)
Create installer for Adblock Plus for IE
| Reported by: | eric@adblockplus.org | Assignee: | eric@adblockplus.org |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-1.2-for-Internet-Explorer |
| Module: | Adblock-Plus-for-Internet-Explorer | Keywords: | 2014q3 |
| Cc: | Blocked By: | #49 | |
| Blocking: | Platform: | Internet Explorer | |
| Ready: | no | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description (last modified by eric@adblockplus.org)
Background
Installer in MSI format. Install driver "setup.exe" to deal with MSI deficiences.
Source code in WiX. Build driven by NMAKE.
Taken from https://trello.com/c/tyzPmJTW/242-create-installer-for-adblock-plus-for-ie
What to change
Published installer for end-users
- Create initial version of installer with all legacy behavior
- Replace using 'regsvr32' for DLL registration with direct use of the registry.
- Create 64-bit MSI for 64-bit platforms.
- Implement separate MSIs for 32 bit and 64 bit binaries.
- Make sure updates work.
- Implement 'setup.exe' bundler.
- i18n for the installer. Approach depends upon whether UI is in MSI or bootstrapper
Add per-user installation. (Avoids need to have administration rights for per-machine installation.)- Change HTML directory to match its new location after moving it out of application data directory.
- Obtain graphical assets to customize appearance of installer and integrate them into the installer.
Installer features for developers
- Set ROOTDRIVE and TARGETDIR installer variables. (Avoid drive scan to determine most available space, which can be very slow.)
- Quick install for development-cycle use. (Avoids explicit registration and manual installation for testing.)
Attachments (0)
Change History (11)
comment:2 Changed on 03/11/2014 at 04:22:27 PM by philll
- Blocked By 49 added
comment:3 Changed on 03/11/2014 at 04:25:19 PM by philll
- Component changed from Unknown to ABP-Internet-Explorer
comment:4 Changed on 03/12/2014 at 10:21:37 PM by fhd
- Priority changed from Unknown to P3
- Reporter changed from philll to eric@adblockplus.org
- Status changed from new to assigned
comment:5 Changed on 03/17/2014 at 12:43:16 PM by eric@adblockplus.org
comment:6 Changed on 03/17/2014 at 12:48:10 PM by eric@adblockplus.org
- Description modified (diff)
Removed per-user installation as part of expected changes, because it's impossible. (It's a limitation with how IE uses BHO registry keys.)
comment:7 Changed on 04/30/2014 at 09:50:33 AM by philll
- Status changed from assigned to new
The assigned state will be dropped by #403
comment:8 Changed on 05/22/2014 at 01:29:37 PM by philll
- Keywords 2014q3 added
- Ready unset
comment:9 Changed on 06/05/2014 at 01:14:35 PM by oleksandr
- Milestone set to Adblock-Plus-for-Internet-Explorer-next
comment:10 Changed on 07/24/2014 at 03:00:55 PM by fhd
- Platform set to Internet Explorer
- Priority changed from P3 to P2
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:11 Changed on 08/11/2014 at 11:56:21 AM by fhd
- Resolution set to fixed
- Status changed from reviewing to closed
Let's resolve this. The code landed without review, so we'll have to do some cleanup: #1184.
Note: See
TracTickets for help on using
tickets.
i18n code for installer in this review: http://codereview.adblockplus.org/5394579117309952/