Opened on 12/12/2014 at 01:33:28 PM

Closed on 12/04/2017 at 02:09:56 PM

Last modified on 12/04/2017 at 02:44:10 PM

#1688 closed defect (worksforme)

When a filter is added, it gets added to whitelisted domains without display.

Reported by: passbrains Assignee:
Priority: Unknown Milestone:
Module: User-Interface Keywords: options-page-2017
Cc: greiner, sven, saroyanm Blocked By: #2376
Blocking: Platform: Chrome
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by greiner)

Adapted from https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=ACH-73

Environment

Windows + 8 64bit + Chrome + English
ABP version 1.8.5.1221

How to reproduce

  1. Add the 'ABP' plugin to the Chrome browser.
  2. Press ABP icon and select Options.
  3. Select 'Add your own filters' and add filter @@||timesofindia.indiatimes.com$document .
  4. There is no display. Press 'Whitelisted domains' and see that 'timesofindia.indiatimes.com' exists. 

Whitelisted domains tab can be displayed or a message that 'domain is added to Whitelisted domains' shall be given.

Observed behaviour

Whitelisted domains tab is not displayed. There is no message to user.

Expected behaviour

Whitelisted domains tab can be displayed instead of staying in 'Add your own filters' tab display.

Attachments (1)

3766_1411125458_addFilter.mp4 (507.8 KB) - added by passbrains on 12/12/2014 at 01:33:33 PM.

Download all attachments as: .zip

Change History (10)

Changed on 12/12/2014 at 01:33:33 PM by passbrains

comment:1 Changed on 12/12/2014 at 01:33:37 PM by passbrains

1 - 19 Sep 2014 09:58:59 posted by Timo Scherf
Hello Rajeswari,
could you please upload significant screenshots.
Thanks for your cooperation.
Greetings from passbrains

2 - 19 Sep 2014 11:17:56 posted by Rajeswari Vemuri
Attached video.

comment:2 Changed on 12/13/2014 at 03:08:36 PM by sebastian

  • Cc greiner sven added
  • Component changed from Unknown to User-Interface
  • Description modified (diff)

comment:3 Changed on 01/02/2015 at 01:59:03 PM by greiner

Also see #1749

comment:4 Changed on 01/02/2015 at 02:17:30 PM by sergz

In addition to #1749 although not sure whether it should be in this ticket, on the whitelisted tab the filter is not clear, for example for @@||163.com^$document it shows merely 163.com.

comment:5 Changed on 01/07/2015 at 02:53:43 PM by greiner

  • Blocking 1526 added
  • Description modified (diff)

comment:6 Changed on 06/15/2015 at 11:37:34 AM by saroyanm

  • Blocking 1524 added; 1526 removed

Changed blocking ticket so I can close #1526.

comment:7 Changed on 06/22/2015 at 10:11:45 AM by saroyanm

  • Blocked By 2376 added
  • Blocking 1524 removed
  • Cc saroyanm added

This should be covered after custom filter implementation is done, or maybe that would be already covered in #2376.

comment:8 Changed on 12/04/2017 at 02:09:56 PM by saroyanm

  • Keywords works-in-new-options-page added
  • Resolution set to worksforme
  • Status changed from new to closed
  • Tester set to Unknown

This should be fixed when we launch the new options page, which most probably will be included in the next release:

We currently showing a "example.com" has been whitelisted. (#5169) in the new Options Page in current scenario, though we still have an issue for the filter list mentioned here

comment:9 Changed on 12/04/2017 at 02:44:10 PM by saroyanm

  • Keywords options-page-2017 added; works-in-new-options-page removed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
 
Note: See TracTickets for help on using tickets.