Opened on 04/15/2015 at 07:55:04 PM

Closed on 06/29/2015 at 12:46:08 PM

Last modified on 06/29/2015 at 12:46:32 PM

#2325 closed change (fixed)

Add a way to set settings in libadblockplus for FRP and automatic updates

Reported by: oleksandr Assignee: oleksandr
Priority: Unknown Milestone: Adblock-Plus-for-Internet-Explorer-1.5
Module: Libadblockplus Keywords: large-scale-deployments 2015q2
Cc: fhd, sergz, eric, oleksandr, simona Blocked By:
Blocking: #1491, #1605 Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5653480979038208/

Description

Background

As of now libadblockplus starts updater automatically on launch (by creating a Downloadable instance with TYPE_AUTOMATIC in updater.js). It also derives firstRun property based on FilterStorage.firstRun. We need a way to override these, in order to support disabling of automatic updates and FRP

What to change

Implement settings for libadblockplus so that it's client would be able to override the automatic update and firstRun setting. There should be default values for those settings, so that updates would start automatically, and FRP will be reported if not set otherwise.

Attachments (0)

Change History (9)

comment:1 Changed on 04/16/2015 at 07:31:40 PM by oleksandr

  • Blocking 1605 added

comment:2 Changed on 04/16/2015 at 07:32:02 PM by oleksandr

  • Blocking 1491 added

comment:3 Changed on 04/17/2015 at 12:20:38 AM by oleksandr

  • Summary changed from Add a way to settings in libadblockplus for FRP and automatic updates to Add a way to set settings in libadblockplus for FRP and automatic updates

comment:4 Changed on 04/17/2015 at 04:09:57 AM by oleksandr

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed on 04/17/2015 at 07:21:06 AM by simona

  • Blocking 542 added

comment:6 Changed on 04/20/2015 at 09:19:29 AM by fhd

  • Blocking 542 removed

Removing #542 from blocking - it's already transitively blocked by this through #1491 and #1605.

comment:7 Changed on 04/21/2015 at 09:13:03 AM by fhd

  • Keywords 2015q2 added

comment:8 Changed on 06/29/2015 at 12:46:08 PM by oleksandr

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:9 Changed on 06/29/2015 at 12:46:32 PM by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-1.5

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from oleksandr.
 
Note: See TracTickets for help on using tickets.