Opened on 09/09/2015 at 02:54:06 PM
Closed on 09/09/2015 at 06:22:11 PM
Last modified on 09/16/2015 at 04:58:56 PM
#3039 closed change (fixed)
Generate qunit/index.html using a template and list of scripts in metadata
Reported by: | kzar | Assignee: | kzar |
---|---|---|---|
Priority: | Unknown | Milestone: | Adblock-Plus-1.9.3-for-Chrome-Opera-Safari-next |
Module: | Automation | Keywords: | |
Cc: | sebastian | Blocked By: | |
Blocking: | Platform: | Unknown / Cross platform | |
Ready: | no | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
https://codereview.adblockplus.org/29326188/ |
Description (last modified by kzar)
Background
The Adblock Plus for Chrome extension features some tests which are run from qunit/index.html. That page includes a bunch of JavaScript files which are contain the tests and supporting code. Currently this list of scripts is hard-coded into the HTML source. We now need the ability to easily adjust the list of scripts that are included.
What to change
Make it so that the page qunit/index.html in the adblockpluschrome repository is generated from a template in the buildtools repository called testIndex.html.tmpl. The list of scripts to include should be taken from the general.testScripts option in the metadata. (For a very similar example see background.html.tmpl in the buildtools repository.)
The list of test scripts will need to be added to adblockpluschrome/metadata.common in the general.testScripts option as a space delimited list. At the same time the buildtools dependency will need to be updated.
All changes made to buildtools dependency of adblockpluschrome:
#3039 - Generate qunit/index.html based on metadata
#3017 - Improve metadata file mapping precedence
#3002 - Add and use getDevEnvPath function
#2968 - Implement multi inheritance for metadata files
Hints for testers
These changes should not affect Chrome, Opera and Safari builds:
#3039 Only changes how the test suite index page is generated.
#3017 Has already been tested on Opera, Chrome, Safari and Firefox to ensure the build was not affected at all.
#3002 Is only related to devenv developer builds.
#2968 Adds a muti inheritance functionality for metadata files that we are not using for Opera, Chrome or Safari builds.
Attachments (0)
Change History (6)
comment:1 Changed on 09/09/2015 at 03:37:19 PM by kzar
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 09/09/2015 at 06:22:11 PM by kzar
- Resolution set to fixed
- Status changed from reviewing to closed
comment:6 Changed on 09/16/2015 at 04:58:56 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
https://hg.adblockplus.org/buildtools/rev/1f43b1f15886
https://hg.adblockplus.org/buildtools/rev/df07a6d71978
https://hg.adblockplus.org/adblockpluschrome/rev/649c6dfe1bd8