Opened on 04/21/2016 at 03:32:50 PM
Closed on 07/18/2017 at 12:13:54 PM
#3967 closed change (fixed)
Create directories for mapped files if they don't already exist
| Reported by: | kzar | Assignee: | tlucas |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Automation | Keywords: | goodfirstbug |
| Cc: | sebastian, kvas, jsonesen, tlucas, greiner | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by kzar)
Background
The metadata files support a [mapping] section which allows files to be placed in different locations or given different names when the extensions are built. Currently if the target location for a mapped file is given inside a directory that's not already included it will be skipped.
What to change
Update packager.py so that readMappedFiles only skips over ignored files. For files inside a not included path the path should be added to the self.includedFiles set instead of being skipped.
Attachments (0)
Change History (13)
comment:1 Changed on 04/21/2016 at 03:39:58 PM by kzar
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 04/21/2016 at 05:38:03 PM by kzar
- Blocking 3816 removed
- Priority changed from P2 to Unknown
comment:3 Changed on 07/25/2016 at 01:53:47 PM by kzar
- Priority changed from Unknown to P5
- Ready set
comment:4 Changed on 12/12/2016 at 11:42:03 AM by kzar
comment:5 Changed on 12/12/2016 at 11:42:33 AM by kzar
- Status changed from reviewing to reopened
comment:8 Changed on 07/06/2017 at 02:32:26 PM by sebastian
- Keywords goodfirstbug added
- Priority changed from P5 to P3
comment:9 Changed on 07/13/2017 at 02:36:11 PM by tlucas
- Cc tlucas added
- Owner set to tlucas
comment:10 Changed on 07/14/2017 at 05:36:41 PM by greiner
- Cc greiner added
comment:11 Changed on 07/17/2017 at 09:13:38 AM by tlucas
- Review URL(s) modified (diff)
- Status changed from reopened to reviewing
comment:12 Changed on 07/18/2017 at 12:09:36 PM by abpbot
A commit referencing this issue has landed:
Issue 3967 - Create directories for mapped files when necessary
comment:13 Changed on 07/18/2017 at 12:13:54 PM by tlucas
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
If we go with the new approach as of #3968 then this no longer blocks #3816. Still I don't think this change is a bad idea, unless you object I'll keep it open.