Opened on 08/16/2016 at 02:43:25 PM

Closed on 08/17/2016 at 07:37:36 PM

Last modified on 08/29/2016 at 10:13:17 AM

#4339 closed change (fixed)

Replace M2Crypto by PyCrypto

Reported by: trev Assignee: trev
Priority: P3 Milestone:
Module: Automation Keywords:
Cc: Blocked By: #4336
Blocking: #4376 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29349869/

Description (last modified by trev)

Background

M2Crypto does not support Python 3 and its documentation is a mess. We should be able to do what we need with PyCrypto which does better on both fronts.

What to change

With #4336 dropping signing of Firefox builds, only Chrome and Safari signing has to be updated.

Integration notes

When integrating this change, you should update README file to mention PyCrypto as optional dependency rather than M2Crypto.

Attachments (0)

Change History (5)

comment:1 Changed on 08/16/2016 at 02:45:21 PM by trev

  • Description modified (diff)

comment:2 Changed on 08/16/2016 at 03:02:23 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 08/17/2016 at 07:36:47 PM by abpbot

A commit referencing this issue has landed:
Issue 4339 - Replace M2Crypto by PyCrypto

comment:4 Changed on 08/17/2016 at 07:37:36 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed on 08/29/2016 at 10:13:17 AM by sebastian

  • Blocking 4376 added

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
 
Note: See TracTickets for help on using tickets.