Opened on 08/29/2016 at 10:13:17 AM
Closed on 09/13/2016 at 07:00:43 PM
Last modified on 10/25/2016 at 04:36:44 AM
#4376 closed change (fixed)
Update buildtools dependency
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-1.12.4-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | #4047, #4339, #4340, #4375, #4382 | |
| Blocking: | #4429 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by sebastian)
Background
Most notably, this dependency update improves the way jshydra (i.e the [convert_js] section) can be configured (#4047).
Moreover, we did some improvements under the hood, mostly to prepare for Python 3 (#4339, #4375, #4382), however we are not there yet. And xar is no longer required to generate Safari builds (#4340).
What to change
- Update the dependencies file to refer to the revisions that include the mentioned changes.
- Adapt the [convert_js] section in the metadata.* files for the new format.
- Update the README: We no longer depend on xar and M2Crypto, but use PyCrypto instead now.
Hints for testers
- The new mechanism to configure JavaScript modules is inevitably changing the order of the modules. This should not be a problem, but who knows. In particular the code that is only used on either Chrome/Safari is effected (e.g. popup blocking, the devtools panel and uninstallation page on Chrome, and Content Blocker support on Safari).
- We also replaced the crypto library, which might effect our self-signed development builds for Chrome and Safari.
Attachments (0)
Change History (7)
comment:1 Changed on 08/29/2016 at 10:15:09 AM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 09/09/2016 at 02:44:17 PM by sebastian
- Blocked By 4382 added
- Description modified (diff)
comment:3 Changed on 09/13/2016 at 06:59:15 PM by abpbot
comment:4 Changed on 09/13/2016 at 07:00:43 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 09/14/2016 at 09:06:19 AM by kzar
- Blocking 4429 added
comment:6 Changed on 10/25/2016 at 04:25:42 AM by rraceanu
No issues encountered, verified on ABP version 1.12.2.1670, 1.12.1.1630, 1.12.0.1620, platforms Chrome 45, 54, Opera 35, 40 and Safari 7, 9.
Last edited on 10/25/2016 at 04:36:44 AM
by rraceanu
comment:7 Changed on 10/25/2016 at 04:26:09 AM by rraceanu
- Verified working set
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 4376 - Updated buildtools dependency