Opened on 10/05/2017 at 07:42:32 PM
Closed on 10/11/2017 at 06:38:55 PM
#5836 closed change (fixed)
Update buildtools dependency and adapt for locale changes
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | Blocked By: | #5751, #5763 | |
| Blocking: | #5837 | Platform: | Unknown / Cross platform |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by sebastian)
Background
With #5763, all projects need to use the same language codes (i.e. no region suffix except for en-*, es-*, pt-* and zh-*), while previously some projects used Chrome-specifc locales, and others (including adblockplusui) used Firefox-specifc locales.
With #5751, language codes in names of the locale/* sub-directories must always use underscores, while previously some projects (including adblockplusui) could use dashes.
This dependency update also fixes compatibility with the Crowdin API (#4836, #5777 and #5815), which currently is broken.
Any other change in buildtools since the last dependency update doesn't effect adblockplusui.
What to change
Attachments (0)
Change History (8)
comment:1 Changed on 10/05/2017 at 07:46:18 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 10/05/2017 at 08:23:27 PM by sebastian
- Blocking 5837 added
comment:5 Changed on 10/10/2017 at 05:36:28 PM by kzar
- Description modified (diff)
Sorry in the rush I updated the wrong ticket! Ignore the above comment.
comment:7 Changed on 10/11/2017 at 06:38:32 PM by abpbot
A commit referencing this issue has landed:
Issue 5836 - Update buildtools dependency and adapt for locale changes
comment:8 Changed on 10/11/2017 at 06:38:55 PM by sebastian
- Resolution set to fixed
- Status changed from reviewing to closed
I've added some quick integration notes for the webpack changes as Sebastian requested in IRC, since I have to leave now that's all I have time for but I can add more information later if necessary.