Opened on 11/03/2017 at 11:01:00 AM

Closed on 11/03/2017 at 11:24:52 AM

Last modified on 11/03/2017 at 11:28:58 AM

#5982 closed change (fixed)

Update adblockplusui dependency to revision 17972505c6b4

Reported by: trev Assignee: trev
Priority: P2 Milestone: Adblock-Plus-3.0-for-Firefox
Module: Platform Keywords:
Cc: kzar, sebastian Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29596617/

Description

Background

We implemented a number of UI fixes, these need to land in Adblock Plus for Chrome and Firefox:

#5949
pfaa link is broken
#5952
Clicking Cancel in the issue reporter doesn't close the tab
#5955
DNT message in Firefox targets Chrome
#5967
Cannot send issue reports from older browsers
#5975
[webextension] Report link does nothing in Firefox issue reporter


Note that for #5949 this is only about the link being opened in a new tab.

What to change

Updating dependency should be sufficient.

Attachments (0)

Change History (4)

comment:1 Changed on 11/03/2017 at 11:04:03 AM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 11/03/2017 at 11:24:22 AM by abpbot

A commit referencing this issue has landed:
​Issue 5982 - Update adblockplusui dependency to revision 17972505c6b4

comment:3 Changed on 11/03/2017 at 11:24:52 AM by trev

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed on 11/03/2017 at 11:28:58 AM by kzar

  • Cc kzar sebastian added
  • Priority changed from Unknown to P2
  • Ready set

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.