Opened on 05/27/2015 at 02:44:46 PM
Closed on 05/17/2016 at 02:17:34 PM
#2596 closed change (fixed)
[Move core logic into adblockpluscore repository] Change adblockplus dependency to adblockpluscore in libadblockplus
Reported by: | kzar | Assignee: | sergz |
---|---|---|---|
Priority: | P2 | Milestone: | |
Module: | Libadblockplus | Keywords: | |
Cc: | fhd | Blocked By: | #2594, #3613 |
Blocking: | #2593 | Platform: | Unknown |
Ready: | yes | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description (last modified by sergz)
Background
Once we have successfully moved the core logic from adblockplus to adblockpluscore #2594 we need to replace the adblockplus dependency with adblockpluscore in the libadblockplus repository.
What to change
Replace the adblockplus dependency with adblockpluscore in the libadblockplus repository and ensure the required core code is still included.
Use adblockpluscore at the newer revision hg:82c88024773b, (currently corresponding revision is adblockpluscore:hg:4a2dceec386a==adblockplus:hg:813682c7161e, see #3337).
The changes imported by this are:
changes without issues:
74987c2906ac | Noissue - Removed redundant URL compatibility logic | Sebastian Noack |
Attachments (0)
Change History (9)
comment:1 Changed on 05/27/2015 at 02:47:40 PM by kzar
- Blocked By 2594 added
comment:2 Changed on 01/11/2016 at 01:41:50 PM by fhd
- Component changed from Unknown to Libadblockplus
- Ready set
- Tester set to Unknown
comment:3 Changed on 02/02/2016 at 01:01:00 PM by sergz
- Blocked By 3613 added
comment:4 Changed on 02/04/2016 at 11:56:48 AM by fhd
- Owner set to sergz
comment:5 Changed on 02/04/2016 at 12:00:14 PM by fhd
- Priority changed from Unknown to P2
comment:7 Changed on 04/20/2016 at 06:35:12 AM by sergz
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:8 Changed on 05/17/2016 at 01:46:36 PM by abpbot
A commit referencing this issue has landed:
https://hg.adblockplus.org/libadblockplus/rev/a9228228ff02
comment:9 Changed on 05/17/2016 at 02:17:34 PM by sergz
- Resolution set to fixed
- Status changed from reviewing to closed
Assigning to sergz, since he's actually looking into that.