Opened on 03/29/2017 at 12:08:40 PM
Closed on 03/29/2017 at 02:11:17 PM
Last modified on 05/23/2017 at 02:47:06 PM
#5055 closed change (fixed)
Update adblockpluscore dependency to revision d0715e99bd3b and adblockplusui to 8ceaabb9c639
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-2.9-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | Blocked By: | #4915 | |
| Blocking: | #5048 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by trev)
Background
We need to update both dependencies at the same time because of #3672 which affects both.
From adblockpluscore this imports:
- #3672 - Anti-adblock notification change
- #4246, #4911, #4962, #5037 - Element hiding emulation changes
- #4838, #4956 - not part of the build
- #4878 - changes to all components that in theory shouldn't have any impact
- https://hg.adblockplus.org/adblockpluscore/rev/5820ed9ef665 - only license headers changed, no code changes
From adblockplusui this imports:
- https://hg.adblockplus.org/adblockplusui/rev/83e07cd4b997, #4644, https://hg.adblockplus.org/adblockplusui/rev/8c7170b4e74f, https://hg.adblockplus.org/adblockplusui/rev/575d910d9d2e, https://hg.adblockplus.org/adblockplusui/rev/aa742e05d752, https://hg.adblockplus.org/adblockplusui/rev/d2b2a7e87ef4 - not part of the build.
- #3672, #4915, #5019 - Anti-adblock notification changes
- #4783, #4968 - API change in messageResponder
- #4871 - changes to all components that in theory shouldn't have any impact
- https://hg.adblockplus.org/adblockplusui/rev/8ceaabb9c639 - only license headers changed, no code changes
What to change
With the remaining part of #4915 resolved, the following changes should be necessary:
- Adjust mapping for antiAdblockInit.js to make it imported from adblockplusui.
- Calling handler.load() in lib/child/elemHideEmulation.js is no longer necessary, handler.apply() is sufficient.
- Adjust EventTarget API for messageResponder (outlined under https://issues.adblockplus.org/ticket/4968#comment:10).
What to test
Due to massive changes in #4878 and #4871 all extension functionality needs to be retested. Focus areas are:
- Anti-adblock notification
- CSS property filters (display in blockable items list changed, now showing the effective selector in the "Address" column)
- First-run page
Note that the extension should no longer install in Firefox 38 and 39, it isn't compatible with those due to changes on #4878. Everything should work in Firefox 40 however.
Attachments (0)
Change History (12)
comment:2 Changed on 03/29/2017 at 12:15:08 PM by trev
- Blocking 5048 added
comment:3 Changed on 03/29/2017 at 12:30:28 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 03/29/2017 at 02:10:48 PM by abpbot
comment:6 Changed on 03/29/2017 at 02:11:17 PM by trev
- Resolution set to fixed
- Status changed from reviewing to closed
comment:7 Changed on 03/29/2017 at 02:11:34 PM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
comment:8 Changed on 03/30/2017 at 10:19:22 AM by abpbot
A commit referencing this issue has landed:
Issue 5055 - Require at least Firefox 40, current core revision isn't compatible with older versions
comment:10 Changed on 03/30/2017 at 10:21:01 AM by trev
- Description modified (diff)
comment:11 Changed on 05/22/2017 at 12:17:46 PM by Ross
Note: Minimum supported version is now Firefox 51 (#5222).
comment:12 Changed on 05/23/2017 at 02:47:06 PM by Ross
- Verified working set
All of the functionality I can think to test appears to be working correctly, specifically checked the anti-adblock notification, FRP, CSS property filters, blockable items list.
ABP 2.8.2.4246-beta
Firefox 51 / 53 / Dev (54) / Windows 7
A commit referencing this issue has landed:
Issue 5055 - Update adblockpluscore dependency to revision d0715e99bd3b and adblockplusui to 8ceaabb9c639