Opened on 04/29/2015 at 02:47:09 PM
Closed on 05/29/2015 at 07:57:25 PM
Last modified on 05/29/2015 at 08:22:31 PM
#2437 closed change (fixed)
Update adblockplus dependency to revision 752ffe2eeaf1
Reported by: | fhd | Assignee: | fhd |
---|---|---|---|
Priority: | P3 | Milestone: | |
Module: | Libadblockplus | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Platform: | Unknown | |
Ready: | yes | Confidential: | no |
Tester: | Verified working: | no | |
Review URL(s): |
Description (last modified by fhd)
Background
We want to update the adblockplus dependency to version 2.6.9 (revision 752ffe2eeaf1), primarily to be able to use ensure_dependencies.py.
The list of changes imported by this is long:
#130, #139, #206, #290, #362, #427, #430, #431, #432, #455, #537, #580, #653, #656, #660, #690, #716, #764, #1129, #1133, #1161, #1241, #1273, #1381, #1479, #1510, #1534, #1588, #1668, #1670, #1675, #1706, #1712, #1713, #1765, #1813, #2004, #2010, #2020, #2041, #2060, #2085, #2093, #2151, #2177, #2225, #2236
The list of relevant (i.e. Core module) changes is luckily shorter:
#427 - Refactoring touching pretty much everything in Core.
#430 - Hit counting changes that shouldn't bother libadblockplus.
#431/#432 - $sitekey-related changes that shouldn't bother libadblockplus.
#537 - Adds the downloadCount parameter to notification/subscription downloads.
#653 - Refactoring touching filterClasses and filterStorage.
#656 - Refactoring touch various Core files.
#1273 - Workaround for a JavaScriptCore bug.
#1588 - Adds ensure_dependencies.py.
#1675 - Refactoring touching filterClasses.
#2177 - Small matching optimisation, just reordering a condition.
#2225 - Updates ensure_dependencies.py (as far as libadblockplus is concerned, buildtools is not used for anything else).
What to change
Update the adblockplus dependency to revision 752ffe2eeaf1.
Attachments (0)
Change History (7)
comment:1 Changed on 04/29/2015 at 04:34:04 PM by fhd
- Description modified (diff)
- Owner set to fhd
- Ready set
comment:3 Changed on 04/29/2015 at 04:50:10 PM by fhd
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 04/29/2015 at 04:52:26 PM by sebastian
comment:5 Changed on 04/29/2015 at 04:54:05 PM by fhd
It's version 2.6.9, the current release. We're usually trying to update to a release version rather than something inbetween.
comment:6 Changed on 05/29/2015 at 07:57:25 PM by fhd
- Resolution set to fixed
- Status changed from reviewing to closed
Note that this version is quite outdated meanwhile.