Opened on 03/12/2018 at 02:46:44 PM
Closed on 08/29/2019 at 05:43:52 PM
#6470 closed change (rejected)
Update buildtools dependency to revision hg:7ee9ad9b9390
Reported by: | sergz | Assignee: | |
---|---|---|---|
Priority: | P4 | Milestone: | |
Module: | Core | Keywords: | closed-in-favor-of-gitlab |
Cc: | kzar, tlucas | Blocked By: | |
Blocking: | Platform: | Unknown / Cross platform | |
Ready: | no | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description
Background
The list of changes imported by this is:
7ee9ad9b9390 | Noissue - Prepare for absolute paths in flake8-per-file-ignores 0.5 | Sebastian Noack |
8ed981af2b75 | Noissue - Drop support for Firefox 50 | Manish Jethani |
79688f4a4aff | Noissue - Make comparable_xml safe against ambiguous tags | Tristan Lucas |
4d26be1c438e | Noissue - Use sets in build.py were appropriate | Tristan Lucas |
5c275f316334 | Noissue - Removed superfluos per-file-ignore for A103, fixing an X100 | Sebastian Noack |
2ee884010cf5 | Noissue - Fixed order of entries in package-lock.json | Sebastian Noack |
293593da6033 | Noissue - Added flake8-docstrings | Sebastian Noack |
94770c909a2d | Noissue - Replace flake8-putty with flake8-per-file-ignores, update to flake8 3 | Sebastian Noack |
64e5f6c97e81 | Noissue - Remove some dead code | Wladimir Palant |
e2a22ff89969 | Noissue - Fixed new flake8 errors | Sebastian Noack |
251daeabfd82 | Noissue - Add Jinja2 requirement to README | Dave Barker |
22d7d801a0b9 | Noissue - Add README | Dave Barker |
e120a0d93303 | Noissue - Adapt quotes for compliance with our coding style | Sebastian Noack |
0a21b061b2fb | Noissue - Got rid of non-defualt script encodings | Sebastian Noack |
cf27cafe5595 | Noissue - Added flake8/tox configuration | Sebastian Noack |
What to change
Beside dependencies and ensure_dependencies.py pay attention to the content of README.md, it might should be changed in accordance with new features of buildtools, and ensure that all scripts like, e.g. generate_docs.py are still working.
Attachments (0)
Change History (3)
comment:1 Changed on 03/19/2018 at 05:25:51 PM by kzar
comment:2 Changed on 03/19/2018 at 05:26:29 PM by kzar
- Cc tlucas added
comment:3 Changed on 08/29/2019 at 05:43:52 PM by sebastian
- Keywords closed-in-favor-of-gitlab added
- Resolution set to rejected
- Status changed from new to closed
Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.
Note: See
TracTickets for help on using
tickets.
Please add some more information to the issue description:
Also I wonder why there are two tables of revisions in the description is that a mistake? Also it would be useful to mention adblockpluscore in the subject, since it's not immediately obvious which repository we're talking about so far.